split invalidate_randomly into two deterministic tests#23280
Draft
cburroughs wants to merge 1 commit intopantsbuild:mainfrom
Draft
split invalidate_randomly into two deterministic tests#23280cburroughs wants to merge 1 commit intopantsbuild:mainfrom
cburroughs wants to merge 1 commit intopantsbuild:mainfrom
Conversation
This test was identified as flaky in 2020 and went through a prior re-enable/backout dance. On my workstation with no load I can run it 1000 times without error. Under artificial cpu load (nice + dummy procs) it fails ~20% of the time. So I think this is a straightforward timing based assertion problem. To "fix" this, the test is broken out into two smaller tests: * An assertion on small deterministic inputs. * Liveness under random invalidation. I think the ideal fix would be some sort of fuzz or property based testing system. But since we one hasn't been adopted already and this test has hung out for six years, I think this is a positive incremental move forward. closes pantsbuild#10839 Notice: A LLM both did the "run the tests a bunch scripting" and geneated the final code. I made the call on splitting versus futzing with timeouts or high scope logical clock changes.
cburroughs
added
the
release-notes:not-required
Contributor
Author
|
@jsanders would you mind taking a look at this rust code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was identified as flaky in 2020 and went through a prior re-enable/backout dance. On my workstation with no load I can run it 1000 times without error. Under artificial cpu load (nice + dummy procs) it fails ~20% of the time. So I think this is a straightforward timing based assertion problem.
To "fix" this, the test is broken out into two smaller tests:
I think the ideal fix would be some sort of fuzz or property based testing system. But since we one hasn't been adopted already and this test has hung out for six years, I think this is a positive incremental move forward.
closes #10839
Notice: A LLM both did the "run the tests a bunch scripting" and geneated the final code. I made the call on splitting versus futzing with timeouts or high scope logical clock changes.